Frame Shift Module to Correct Timing in Data - PR For Develop by VCLanNguyen · Pull Request #804 · SBNSoftware/sbndcode

VCLanNguyen · 2025-08-30T00:57:53Z

Description

New module for timing reconstruction. Module make data products for downstream reconstruction.
Add to reco2 workflow
Description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
sbnobj dev: SBNSoftware/sbnobj#142
sbnanaobj dev: SBNSoftware/sbnanaobj#154
sbndcode dev: #804
sbncode dev: SBNSoftware/sbncode#562

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

…ftware/sbndcode into lnguyen/frame_shift_pr_dev

nathanielerowe · 2025-09-09T19:04:05Z

PR is identical to prod patch so a reviewer won't be pinged unless you feel it is needed @VCLanNguyen

nathanielerowe · 2025-09-10T02:55:41Z

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj@v10_01_02 SBNSoftware/sbnanaobj@v10_00_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00

FNALbuild · 2025-09-10T03:14:52Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-10T03:15:50Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-10T03:25:55Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-10T03:29:12Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-09-10T03:37:09Z

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode#562 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj#142 SBNSoftware/sbnanaobj#154 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00

FNALbuild · 2025-09-10T03:51:01Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-10T03:53:50Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-10T04:00:43Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-10T04:12:47Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-09-11T03:22:44Z

@VCLanNguyen Some changes appeard in the offbeam CAFs when running CI. Are these values meaningful in anyway? If not can we set them to reasonable default values?

1222: Checking record 0
1223:   rec.hdr.triggerinfo.beam_gate_time_abs differs: 4294967295 vs 18446744073709551615
1224:   rec.hdr.triggerinfo.global_trigger_time differs: 4294967295 vs 18446744073709551615
1225:   rec.hdr.triggerinfo.trigger_within_gate differs: 0.0 vs nan
1226: Checking record 1
1227:   rec.hdr.triggerinfo.beam_gate_time_abs differs: 4294967295 vs 18446744073709551615
1228:   rec.hdr.triggerinfo.global_trigger_time differs: 4294967295 vs 18446744073709551615
1229:   rec.hdr.triggerinfo.trigger_within_gate differs: 0.0 vs nan
1230: Checking record 2
1231:   rec.hdr.triggerinfo.beam_gate_time_abs differs: 4294967295 vs 18446744073709551615
1232:   rec.hdr.triggerinfo.global_trigger_time differs: 4294967295 vs 18446744073709551615
1233:   rec.hdr.triggerinfo.trigger_within_gate differs: 0.0 vs nan
1234: Checking record 3
1235:   rec.hdr.triggerinfo.beam_gate_time_abs differs: 4294967295 vs 18446744073709551615
1236:   rec.hdr.triggerinfo.global_trigger_time differs: 4294967295 vs 18446744073709551615
1237:   rec.hdr.triggerinfo.trigger_within_gate differs: 0.0 vs nan
1238: Checking record 4
1239:   rec.hdr.triggerinfo.beam_gate_time_abs differs: 4294967295 vs 18446744073709551615
1240:   rec.hdr.triggerinfo.global_trigger_time differs: 4294967295 vs 18446744073709551615
1241:   rec.hdr.triggerinfo.trigger_within_gate differs: 0.0 vs nan

VCLanNguyen · 2025-09-15T19:13:41Z

I added to the issue with filling SRTrigger product for SBND: https://github.com/SBNSoftware/sbncode/blob/508e45f04b9d4262a2bfd6f26b128e2b763f4b5c/sbncode/CAFMaker/FillTrigger.cxx#L37

I will circle back to this sometime in the future.
At the moment, all the timing information should be available as CAF frame shift products. SRTrigger is just duplicated information from CAF frame shift products.

VCLanNguyen and others added 10 commits August 6, 2025 00:44

first commit

122a30f

Add a new object TimingInfo to store timestamp in unix format

5101e17

add saving additional info

b7f0f0e

add frame shift to reco2 fcl

723fb04

add a new variable to correct at CAF

5c54fc7

add reco2 fcl + some fixes

900f35b

Turn missing TDC products exception to a log

33ec1e8

move products from sbndcode to sbnobj

99b86e4

remove comments

1af3843

Merge branch 'develop' into lnguyen/frame_shift_pr_dev

de19ba6

VCLanNguyen marked this pull request as ready for review August 30, 2025 00:59

VCLanNguyen added reco1/reco2 Reconstruction breaking change labels Aug 30, 2025

VCLanNguyen self-assigned this Aug 30, 2025

VCLanNguyen requested review from JosiePaton and lynnt20 August 30, 2025 01:10

VCLanNguyen linked an issue Aug 30, 2025 that may be closed by this pull request

Timing Module for Data/MC and Beam/Offbeam Agreement #757

Closed

2 tasks

linyan-w added this to SBND 2025 Fall Production Sep 2, 2025

linyan-w moved this to Todo in SBND 2025 Fall Production Sep 2, 2025

VCLanNguyen added 6 commits September 4, 2025 12:23

add new flag to enable/disable timing correction in caf

26d3a62

add caf maker fcl parameter

824a872

add labels to fcl

82fd24f

move parameters to fcl

ae64879

set default debug as false

98de997

Merge branch 'lnguyen/frame_shift_pr_dev' of https://github.com/SBNSo…

a8a01c9

…ftware/sbndcode into lnguyen/frame_shift_pr_dev

linyan-w moved this from Todo to To be merged in SBND 2025 Fall Production Sep 10, 2025

nathanielerowe moved this from Ready for CI to Flagged by CI in SBND 2025 Fall Production Sep 11, 2025

JosiePaton approved these changes Sep 11, 2025

View reviewed changes

nathanielerowe moved this from Flagged by CI to RM Approved in SBND 2025 Fall Production Sep 15, 2025

nathanielerowe added 2 commits September 16, 2025 08:28

Merge branch 'develop' into lnguyen/frame_shift_pr_dev

7161277

Merge branch 'develop' into lnguyen/frame_shift_pr_dev

2d76cd9

nathanielerowe merged commit 7460895 into develop Sep 16, 2025

nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Sep 16, 2025

linyan-w mentioned this pull request Sep 16, 2025

Move frameshift to bnb streams only #823

Closed

7 tasks

Conversation

VCLanNguyen commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

nathanielerowe commented Sep 9, 2025

Uh oh!

nathanielerowe commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

nathanielerowe commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

FNALbuild commented Sep 10, 2025

Uh oh!

nathanielerowe commented Sep 11, 2025

Uh oh!

VCLanNguyen commented Sep 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VCLanNguyen commented Aug 30, 2025 •

edited

Loading